The 24VAC transformer is the one that comes with the Jandy Aqualink RS System. (as you pointed out)
The 24VDC transformer powers the DPST relays that also came with the Jandy Aqualink RS System.
The thing is, the Control Board on the Jandy Aqualink RS (JARS) does the rectifying on board. So, I had 3 options
In the end, I knew when I expanded I'd need more low voltage DC power, and I could get it next day on Amazon, so I went with the separate DC power supply.
What is Janky about my system? :'( It's actually much cleaner than the JARS.
I agree, the pool guy wants me to have a good experience. And yes, Jandy makes a product that is robust. I'm not bashing the pool guy by pointing out that the $2000 system he has available through his company, can be built with simple components, that are simpler to operate and maintain. And my system costs less than $200.
Contrary to your claim, the system I've built is much simpler, and much easier to upgrade and maintain/use, while costing significantly less. And if something goes wrong, I have an open market of suppliers that can upgrade it.
Due to the massive gains in consumer electronics, IoT and Smart Home assistants, the pool industry is ripe for technological disruption in the automation market. The duopoly that they've enjoyed on the pool controllers will likely come crashing down.
$28 SONOFF 4CHPROR3
And if you don't have them already:
$30 DPST relays (or the AC version for $28)
$138 Jandy valves