Development definitely hasn't stopped, we've got the v1.9.9 release probably coming this weekend:
https://github.com/QuantumBadger/RedReader/blob/master/assets/changelog.txt
I don't spend as much time working on the app as I used to, but I still fix any big issues, merge in the pull requests which come my way, and occasionally code new features (see everything in that changelog without "thanks to" after it :))
v1.8.7.8 :)
List of changes/features here: https://github.com/QuantumBadger/RedReader/blob/master/assets/changelog.txt
After that, probably v1.9.0. I'm hoping for it to contain a main menu rendered with OpenGL (as a prototype/trial run for the v2 post/comment lists done in OpenGL), and oAuth support (which needs to be done soon, or the app will stop working).
I've decided to start backporting features from v2 into the v1 branch, since v2 is taking so long. Among them is the ability to subscribe to and unsubscribe from subreddits, which will be in the next version (v1.8.5).
I'm still working on it -- there seem to be a few bugs introduced by the exorcism of HoloEverywhere, so those still need fixing before release.
Here's a list of features implemented so far in v1.9.0:
https://github.com/QuantumBadger/RedReader/blob/master/assets/changelog.txt
Dammit!
This seems to be the commit which introduced the issue (my fault):
https://github.com/QuantumBadger/RedReader/commit/c8321b99bd771313af31399ce13b2d92f97b1c9b
I have a rough idea why it's happening and will produce a fix ASAP.
Unfortunately reddit changed their API in way that broke this. It's been fixed in the latest alpha:
https://github.com/QuantumBadger/RedReader/commit/88f06e64a28f02bdedc37cafebe2186066160de9
Thanks for letting me know! Links which are rejected by the external browser will no longer cause a crash in v1.9.0:
https://github.com/QuantumBadger/RedReader/commit/f07419a55232f0aa94c340a32af7ad5912798236
Just responded by PM :)
Reddit has a bug where new accounts have an empty subscription list (via the API). So, if RedReader detects an empty list, it has to decide which subreddits to show itself.
If old versions of RedReader detected an empty list, they would show a list of subreddits with the most subscriptions, which I think included /r/4chan.
Newer versions have the list of defaults hardcoded:
So, try upgrading if you aren't on v1.8.7.8 :)
It is for my setup, as far as I know those settings work.
This is more of a bug when waiting for an internet connection because the app wants to automatically add new comments to the cache.
The offending option was I think introduced on version 1.10:
https://github.com/QuantumBadger/RedReader/releases/tag/v1.10
This can either be fixed by an option to disable this or maybe an offline mode.
From my experience this happened even before this setting was introduced but to a lesser degree. Some function of the app waits for an internet connection before entering cached views.
You can post an issue on Github if this happens to you so much:
We were already handling RTL marks, but it turns out Unicode also has "RTL override marks", which are like a stronger version of them. Unicode is pretty evil like that :(
Fixed here:
https://github.com/QuantumBadger/RedReader/commit/708865e5b144091b7ead8b183ca291ad12d3c066
Should be in Alpha 180.
Thanks for letting us know!
> We hope to become a charity one day. I hope that's OK under your open source license.
Even commercial usage is fine under the GPL, so long as you stick to the terms (e.g. making your derived app open source).
> How do I increase the size of the fonts on the front page of the app?
The XML file for this is here:
https://github.com/QuantumBadger/RedReader/blob/master/src/main/res/layout/reddit_post.xml
> What is the best strategy for adding fonts like Raleway + Montserrat?
There are already some custom fonts in the app, so feel free to use what's there already as inspiration:
https://github.com/QuantumBadger/RedReader/tree/master/assets/fonts
Good luck with your project :)
Thanks, I've opened a ticket here:
https://github.com/QuantumBadger/RedReader/issues/505
In the meantime you can get the /r/popular experience by going to /r/all and blocking the political/NSFW subs :)
Thanks for the report. What sort of device are you on? (and what Android version/ROM?)
The app basically just uses Android's Bitmap APIs for decoding images:
If Android doesn't like the image for some reason, the app reverts to the browser.
Please let me know if you have any links to specific images which cause this.
It's possible, and someone partially implemented it. It'll probably be added at some point (maybe by me).
Something I'd also like is an option to be able to exclude all my front-page subs from /r/all and only see those I'm not subscribed to, which would be easy to do once the above feature is done.
> Hide the table in the post by default, have a button which expands to show the table (either inline or a separate page)
This is the plan (have a button which opens a new page). Unfortunately RR's markdown parser is diabolical, and I'm not looking forward to making the changes :)
The full code's here if anyone's interested:
No need, I just released it a few minutes ago :)
http://www.reddit.com/r/RedReader/comments/2c9zzz/version_186_released/
A live version of the changelog which appears when the app starts after an update is available here:
https://github.com/QuantumBadger/RedReader/blob/master/assets/changelog.txt
It gets updated every time I add a feature. There's also the commit log (as /u/zagaberoo mentioned) if you'd like more detail.
There are instructions for building the app with IntelliJ IDEA here. It won't be too different with Eclipse, just make sure you have the Android SDK set up. Then this answer on SO explains a bit about how to get going with a Maven project in Eclipse.
Good luck!
You can get APKs off of F-Droid:
https://f-droid.org/repository/browse/?fdid=org.quantumbadger.redreader
Also the alpha versions are pretty stable, with only a few minor bugs.
I don't think it's possible to upload binaries to GitHub any more (unless you mean putting them in a repo, but I don't think that would be a good idea).
This could potentially be related to the ListView changes I made in v1.9.2.
Please could you download 1.9.1 from here, and let me know if the problem is still there?
https://f-droid.org/repository/browse/?fdid=org.quantumbadger.redreader
Build seems to be failing on F-Droid.
INFO: Creating log directory INFO: Creating temporary directory INFO: Creating output directory INFO: Building version 1.9.0 (63) of org.quantumbadger.redreader INFO: Getting source for revision v1.9.0 INFO: Creating local.properties file at build/org.quantumbadger.redreader/local.properties INFO: Running 'prebuild' commands in build/org.quantumbadger.redreader Could not build app org.quantumbadger.redreader due to BuildException: Error running prebuild command for org.quantumbadger.redreader:1.9.0 ==== detail begin ==== + sed -i 's@<version>3.8.0</version>@<version>3.7.0</version>@g' pom.xml sed: can't read pom.xml: No such file or directory ==== detail end ====
There is a pull request already up on Github.
https://github.com/QuantumBadger/RedReader/pull/636
Once QuantumBadger merges it the problem should be fixed, a 1.9.9 was already in the works, this should speed it up.
Thanks for the report, unfortunately imgur limits the number of images we can upload every month.
> Each application can allow approximately 1,250 uploads per day or approximately 12,500 requests per day. If the daily limit is hit five times in a month, then the app will be blocked for the rest of the month.
There's a GitHub ticket about this here:
https://github.com/QuantumBadger/RedReader/issues/409
> Would it be possible for the app developers to allow us to directly upload to Reddit, as a new upgraded feature please?
Reddit don't allow app developers to do this as far as I'm aware -- they've kept the API private.
Support for other image hosts may be added in the future, although it's not a big priority (because it's possible to upload using a browser).
Thanks for the report, unfortunately imgur limits the number of images we can upload every month.
> Each application can allow approximately 1,250 uploads per day or approximately 12,500 requests per day. If the daily limit is hit five times in a month, then the app will be blocked for the rest of the month.
There's a GitHub ticket about this here:
Thanks for the suggestions! Support for the new gfycat links has been added in the latest release (v1.9.8.3, out a few moments ago):
https://www.reddit.com/r/RedReader/comments/77fc8l/version_1983_released/
I've opened a GitHub issue about the toolbar for albums:
https://github.com/QuantumBadger/RedReader/issues/537
> Last request, can you make the Imgur toolbar available in images from the comments?
Is this so you can save images? If so, try long-clicking the link button :) Same thing in albums -- I think you can long click items in the list.
Thanks for the suggestion. I've taken a look at the reddit API and unfortunately I can't see a way to retrieve a list of blocked subreddits. If anyone knows how this could be done, please let me know.
There's a GitHub ticket open for Synccit support here:
Thanks for the suggestion! Due to how the app works internally, it would be a massive pain to allow moving between posts from within the comment list/image viewer (although given enough refactoring I'm sure it could be done).
However, I've added a new post/comment swipe preference which allows you to go back to the previous screen. I.e. if you're viewing the comments, you can now swipe to go back to the post list:
https://github.com/QuantumBadger/RedReader/commit/2215e38156d725e609e3a29620a2ded354e55fb6
https://github.com/QuantumBadger/RedReader/commit/921ca7e5ec50181ceaf6483cb08ff10c78340338
It's in Alpha 110, which is up now. Hope that makes things a bit more convenient!
Thanks! I agree that it could do with being a more vivid colour. I went with gray for now, because there's not a colour associated with it on the main site (sticky = green, nsfw = red, spoiler = black on white).
I've opened up a ticket for customising the colours here: https://github.com/QuantumBadger/RedReader/issues/430
Thanks for the suggestions :) I've added the ability to disable inbox replies:
https://github.com/QuantumBadger/RedReader/commit/afb6c59305cbf93ea1ca764a80a12b270c3b28f8
Should be in Alpha 95 in a few mins.
I've had a quick look at the reddit API and can't see anything for title suggestions. Are other apps able to do this somehow?
Thanks for the suggestions! There's a (very old!) ticket for subreddit search open here:
https://github.com/QuantumBadger/RedReader/issues/53
And one for a subreddit album view here:
https://github.com/QuantumBadger/RedReader/issues/305
They're definitely things I'd like to add to the app, if I can get enough time.
Thanks for the suggestion -- it's definitely feasible, it's just a matter of getting time to code all this stuff :)
I've opened up a ticket here:
> any chance we will see support for disabling inbox replies on comments?
I've just opened up a ticket for this here:
https://github.com/QuantumBadger/RedReader/issues/286
It would be fairly simple to add -- if anyone wants to have a go the relevant code is here:
If not, I'm sure I'll eventually get round to it :)
>I can't wait to start filtering out subreddits so that every second post isn't about the US election
~~Did he say this would be a feature? I can't find mention if it~~
I was about to buy reddit gold to see if that would filter them out on mobile to...
edit: woo! top of the list! there is a god and his name is Quantum Badger!
Thanks for the suggestion. I think it would be good to add this to the loading screen (under the circular progress bar, e.g. "1 MB / 15 MB"). I've opened a ticket for this here:
There isn't currently a built-in way of doing this. The app stores settings in an ordinary Android SharedPreferences object -- I'm not sure where these are saved on the device, but it might be possible to get hold of the file using adb (or a file manager app).
I've opened the following ticket to add the functionality to the app:
Which ROM are you using? I've checked here:
https://github.com/QuantumBadger/RedReader/blob/master/src/main/res/layout/reddit_post.xml
And all the relevant heights are wrap_content
, which is correct. I'm guessing that the items in the list aren't being re-measured after the thumbnail loads.
Not sure what's going on with the CAPTCHA -- I'm inclined to say that it's reddit's fault and that's the full image which the app is receiving. It would be possible to find out by getting the CAPTCHA image from RR's cache and opening it in an image viewer, although that's not a simple task.
v1.9.0 still does precaching, but I've added some limits to make sure it doesn't precache ridiculously huge images:
So if an image is bigger than 2500x2500, or larger than 10MB, it won't get precached any more.
Thanks for the suggestions!
> Was just wondering whether multireddits would ever be supported?
Eventually they will be (as will "favourite subreddits"), but I'm really short on time at the moment.
> could you make it so when typing in a custom subreddit it strips any spaces when pressing "Go"?
All whitespace is now stripped from the custom subreddit entry in v1.9.0:
https://github.com/QuantumBadger/RedReader/commit/b9c907b39fb8d17f782d17985e78a48d914b53ba
I thought it was possible to delete comments, but it looks like it's not. So I just added the feature to v1.9.0:
https://github.com/QuantumBadger/RedReader/commit/d1a9f4af59dd4694ff893e9edb30d8fb5add630b
In theory RedReader should use the external cache directory by default, and revert to internal storage if that's not available:
But it looks like Android isn't treating the SD card as external cache in your case.
If you don't mind building from source, it's possible to hard-code a cache dir in the method linked above:
public static File getBestCacheDir(final Context context) { return new File("PATH TO DIR"); }
Thanks for the suggestion -- I've added a preference (in the Behaviour section) that lets you change the size of the swipe zone. It'll be in v1.9.0 (along with an increasingly ridiculous number of other changes):
https://github.com/QuantumBadger/RedReader/commit/1142f9129662ec7d6d75b93d15a1ebd71ea310bc
It's 10dp by default (as before), and you can make it up to 40 dp (which is probably about the same width as the toolbar itself!)
Also, it's worth mentioning that the toolbar works on both sides of the screen, not just the right :)
Unfortunately I don't think there's an easy way to return to the same place you were at in the comments, but I'll keep it in mind.
Done:
https://github.com/QuantumBadger/RedReader/commit/51b8b0e1ad4be1b137d67774eab28dc0ef52cb0a
It's off by default, but once 1.9.0 is out, you will be able to enable the "Close All" item in the options menu, which will close all activities other than the main one.
Oops, looks like I only put in the default list for anonymous users, not new users. I've just fixed that here:
https://github.com/QuantumBadger/RedReader/commit/92393f22d99773718b0f7afdbe60cc1261dd4e38
It should be in v1.9.0.
It took most of the morning, but I've fixed it :) I've also added some Markdown-related unit tests.
https://github.com/QuantumBadger/RedReader/commit/1d8ce7faafd686a23a82b125aea0de111a421c94
Should be in v.1.8.7.8.
This is the code used to detect WiFi connections in RedReader:
Someone has suggested that it occurs when they're connected to a WiFi hotspot that doesn't have internet access -- Android reports WiFi as connected, but puts the internet traffic through the mobile data connection.
I've made a change in v1.8.7.7 which may improve things:
https://github.com/QuantumBadger/RedReader/commit/528745ffc7cb56f8c5d53fa6caff9a7893720c16
Let me know how you get on once the update is released.
Just added the ability to save comments to v1.8.6:
https://github.com/QuantumBadger/RedReader/commit/b5c8ae00e0911df484cb18b98f11220f6bb27010
The ability to list them probably won't be added for a while though (until v2's listview replacement is ready).
Added in v1.8.5 with a couple of other new main menu items, and the ability to choose which items are shown:
https://github.com/QuantumBadger/RedReader/commit/69ceea8c3480a25c1db0abe621fdeb9fe8c1d536
> the ability to unsave items from the saved list without having to re-save them first
Well, crap, now I feel like a complete idiot :)
Fixed in v1.8.5.
You can set the cache to be deleted after 1 hour as min. and 3 monthes as max. Also check if the cache images and comments options are on. (All that is found in Settings -> Cache).
Also, if you want to clear the cache directly you can download Fast Cache Cleaner which is 30 KB in size and clears the cache when you just click it from app drawer (it has no UI etc.. so it's the fastest app that does that).
It'll be cool to have clear cache on exit option though.
Go into your system settings, search for each app by name and set it to always ask to open supported links and file types (pref may be hidden under advanced). I recommend leaving the pref to open supported links in apps off in Firefox. You can always long-press on a link and choose open in external app, or open the ⋮ menu for the page and choose open in app.
To be able to truly choose between opening in your browser and a dedicated app, per link, try <em>Better Open With</em>. You set it as your default browser, email client, etc. Then it will provide a little pop-up for you to choose an actual app each time. It's very customisable and unobtrusive. You can set it to ignore some types of links/file associations completely.
This has been happening for some time now.
Whenever I get this issue I think unless I am remembering a simillar issue with Giphy links.
I personally send these links to this app which opens them fine every time.
https://play.google.com/store/apps/details?id=com.ensoft.imgurviewer
> You can get APKs off of F-Droid: > > > > https://f-droid.org/repository/browse/?fdid=org.quantumbadger.redreader
I'm using F-Droid, I'm just saying that non-Google Play users have to wait a bit longer to update.
I see that updating the F-Droid version using the apk downloaded from Google Play isn't possible (the app isn't installed
error).
FYI
https://github.com/QuantumBadger/RedReader/issues/697
I love RedReader, and you got me curious about battery usage. I just went into settings and disabled the two precache options to see if I notice a difference. :)
If it just has a post at the end and no errors, then I'm not sure. Probably best if you raise an issue on the Github, so QuantumBadger or one of the other contributors can look into it.
Thanks for the comments!
Regarding the issue, I've retested it and it works fine for me, and looking at the code I just don't think there's a realistic way for it to go wrong :) Would you mind sending me a video of what you're seeing please?
Thanks for the details! 12% per hour is about average. From a comment on GitHub a while ago:
> Doing some quick calculations based on those numbers, it looks like RR does pretty well (better than Amazon, and about the same as Firefox): > > RedReader: 10 hours/charge (or 10% lost per hour) > > Amazon Shopping: 8.5 hours/charge (or 12% lost per hour) > > Firefox: 10.5 hours/charge (or 9.7% lost per hour) > > The majority of RR's battery usage is likely precaching images and comments, which can be disabled in the settings (under "Cache").
https://github.com/QuantumBadger/RedReader/issues/697#issuecomment-568212514
So as above, disabling precaching would likely help.
I tried both versions, yours and /u/habnufbart in his app which he now submitted as a pull request (I assume they are the same).
I think his solutions works best mainly because he moves the image below a posts text and fits it to the width of the phone. Your solution to show the image next to the text, leaves no space for the text after a certain value.
Selecting a custom zoom is unnecessarily complicated I think, just a checkmark to show the image inline, and make the image fit the width of the device.
Thanks for letting me know, although I don't have much control over this. F-Droid is supposed to automatically rebuild the app every time I push a new tag:
https://github.com/QuantumBadger/RedReader/tags
From what I can see, the issue is that F-Droid's build servers are running old software, and don't support Gradle 6.5:
This is my main gripe with Red Reader, and it would be a very nice feature. It has been brought up multiple times in the Github issues (see here), so the devs are well aware of this.
It seems that the current behavior of downloading videos instead of streaming them is due to how the cache manager works. Given how the cache manager is used extensively in the app, to pre-load and save media, posts, comments... so they are downloaded only once, I suppose changing how it works to accommodate for video streaming would potentially impact a lot of other things, and would be a complicated task.
I don't know Java well enough to do anything about it but currently it's hard-coded to use the Pictures folder: https://github.com/QuantumBadger/RedReader/blob/22c96d30778fdc1ece8216427b79ca4a7696c129/src/main/java/org/quantumbadger/redreader/image/SaveImageCallback.java#L123
This also happens to me as well. I can also see that the download speeds a much lower for redgifs (around 300 Kbytes/sec)
I noticed this when the redgifs support went live but assumed that redgifs and by extension gfycat were capping redgifs while testing things out.
However opening redgifs outside of RedReader doesn't seem to have these issues.
Thanks for this 👍
I found a bug and opened an issue before I saw this post.
The Reddit post that does not render properly is this one on /r/soccer.
In v1.11 I've completely redesigned the way comment text is shown:
https://github.com/QuantumBadger/RedReader/commit/46852d0a95aa89e7dac8219f9b2ccec481f118b5
This should fix a variety of markdown-related issues with the app, including adding support for the new spoiler syntax.
It's part of Alpha 198 and above:
Please give it a go, and let me know if you run into any comment rendering issues! This is the biggest change to the app in a while, so I'm hoping it'll get lots of testing before the v1.11 release.
I've added two new preferences for this ("Hide post list header toolbar" and "Hide comment list header toolbar"). Should be in Alpha 199: https://redreader.org/alpha/
> On a related note, how difficult would it be to add the "it goes away when you scroll down" functionality to the main title bar in each page, thread, and subreddit?
There's a ticket open for this, although I'm not sure if anyone's looked into it yet:
It was mentioned in the comments of the release announcement, so your best bet is to open an issue on GitHub
Admins just announced it is rolling out for old reddit and in a few weeks will also affect third party apps.
It's a known issue.
It's been fixed in the latest alpha version, you can test it if you want.
At this point we are waiting for /u/QuantumBadger to release an update with the fix.
It's been a while since I was dealing with OAuth2 stuff, but the relevant code is here:
I haven't used retrofit, but when getting the access token, the parameters are sent as ordinary POST fields:
There's a GitHub ticket here for it:
https://github.com/QuantumBadger/RedReader/issues/286
I don't have much time to work on the app these days, but if a contributor submits a patch for it, I'll gladly accept it :)
Yep, long standing issue I'm afraid :(
https://github.com/QuantumBadger/RedReader/issues/200
At the moment RR treats /r/random like any other subreddit, fetching the details and then the content, but that means that they come from different sources.
Thanks for the suggestion! There's an abandoned pull request for this here:
https://github.com/QuantumBadger/RedReader/pull/377
If someone fixes it up I'd be happy to merge it in (or I may get around to it at some point).
> I just did some investigation and it turns out that the answer is to pass the comma-delimited list that you get into the /api/morechildren API in the children parameter
From what I've seen this API is quite unreliable -- other reddit apps (at least in the past) seem to be a bit hit-and-miss when it comes to requesting more comments. Even the reddit site only does it correctly about 75% of the time for me. So one of the main reasons I chose to load the comments one at a time is that it's 100% reliable :)
> I'm sorry, this sounded so arrogant of me
Not at all :) It probably will be quite a simple change.
Feel free to have a go, although I'd want to keep the existing behaviour by default, and make this an optional preference. Here is where the comment IDs are turned into URLs to download:
It would definitely need to be tested before the PR though -- if you're on Linux, setting up the build should just be a case of installing a recent version of Gradle, and the Android SDK.
If by search you mean search a post it has been requested before, QuantumBadger added it as issue on QitHub.
It may be harder to implement, I faintly remember when QuantumBadger was going for a 2.0 release, that he was planning to switch to an alternative to the Android ListView that would allow for text selection in comments. That may be needed for search as well.
Thanks for the suggestion! The reason I wanted the list to appear first was to make it obvious that the user was in an album. If the app took you straight to the first image, I'd have to either:
This could definitely be a preference though (so that, in the settings, you could disable the list and get the toast instead). I've opened a ticket here:
Thanks for the report. There will be a workaround for this in v1.9.0, although ultimately the problem is on imgur's end (presumably with rogue ads taking over the page).
Done:
https://github.com/QuantumBadger/RedReader/commit/a6f2a649bd5c137203a30e2a43860403e1fd3460
There will now be a preference in v1.9.0 which lets you choose one of the following four options:
Movie is the default, and seems to be broken on the S5. Legacy might work for you, but if not you can use either of the browsers. Hope that helps :)
Thanks for the report. Lots of people with Galaxy S5s have mentioned this problem, so I think the problem is related to the Samsung stock ROM somehow. RedReader relies on Android's "Movie" class to play GIFs:
Switching to a custom ROM may well solve this, but I can understand that you might not want to.
In the near future I'll be adding support for .gifv/gfycat files, which use a different rendering method, and hopefully that should lessen the impact of this issue a bit.
I can reproduce the issue with the GIF you linked.
At the moment the app just uses Android's Movie
class to play GIFs:
It seems to be a pretty low quality implementation in general, and sometimes cuts off the end of GIFs. It also crashes a lot.
Probably the best thing would be for the app to abandon all of Google's image decoding libraries, and bundle decent ones as native libraries (or out-of-process executables).
Thanks for the report!
Number (1) sounds like your device is aggressively killing off background activities, and unfortunately RedReader doesn't do a great job of saving state. It is something I'm planning on fixing eventually though :)
Number (2) has been fixed in v1.8.7.7, which I'll be releasing soon:
https://github.com/QuantumBadger/RedReader/commit/c7cb8ef32507b89d2549ef8511d478cd341fef8d
Sorry for the delayed response. RR only uses the json API. You can log all of the requests it makes here (line 92):
I've just taken a look, and it seems as though the Reddit API returns a list of the first message in each thread, and each message has a "replies" field which contains all the other messages in the thread.
I've added a fix here -- it should show up in 1.8.6.4.
Maybe give this a try? I'm working on some features to be pulled into RedReader, so while waiting for quantum badger to approve them I threw them together into another app :)
Redreader probably uses Webview for the sidebar. ROMs usually use an old AOSP version.
You can try updating it or freezing/uninstalling it and installing the Google Play version if you are on Marshmallow or later. You can even try installing it alongside AOSP. In my case Redreader uses the newer version.